Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] throw "TypeError: 'NoneType'..." when save chart to dash #5835

Merged
merged 2 commits into from
Mar 22, 2019
Merged

[bugfix] throw "TypeError: 'NoneType'..." when save chart to dash #5835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f1c94
[bugfix] throw "TypeError: 'NoneType'..." when save chart to new/exis…
hitdemo Sep 6, 2018
b5152b2
Merge remote-tracking branch 'upstream/master'
hitdemo Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,7 +1437,7 @@ def save_or_overwrite_slice(
"""Save or overwrite a slice"""
slice_name = args.get('slice_name')
action = args.get('action')
form_data, _ = self.get_form_data()
form_data, unused_slc = self.get_form_data()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting, I never thought that the gettext standard of using _ conflicts with the python standard for unused assignments


if action in ('saveas'):
if 'slice_id' in form_data:
Expand Down Expand Up @@ -1474,7 +1474,7 @@ def save_or_overwrite_slice(
status=400)

flash(
'Slice [{}] was added to dashboard [{}]'.format(
_('Chart [{}] was added to dashboard [{}]').format(
slc.slice_name,
dash.dashboard_title),
'info')
Expand All @@ -1490,8 +1490,8 @@ def save_or_overwrite_slice(
dashboard_title=request.args.get('new_dashboard_name'),
owners=[g.user] if g.user else [])
flash(
'Dashboard [{}] just got created and slice [{}] was added '
'to it'.format(
_('Dashboard [{}] just got created and chart [{}] was added '
'to it').format(
dash.dashboard_title,
slc.slice_name),
'info')
Expand Down