Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timing to stats logger #5844

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

timifasubaa
Copy link
Contributor

This PR adds the option to log time into the logging interface in superset.

@john-bodley @mistercrunch

@@ -29,6 +29,9 @@ def decr(self, key):
"""Decrement a counter"""
raise NotImplementedError()

def timing(self, key, time_in_milliseconds):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this correctly the value can be either ms or a timedelta object, thus I wonder if time_in_milliseconds should simply be delta or value (for consistency).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. I'll change it.

@codecov-io
Copy link

codecov-io commented Sep 10, 2018

Codecov Report

Merging #5844 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5844      +/-   ##
==========================================
- Coverage   63.73%   63.73%   -0.01%     
==========================================
  Files         368      368              
  Lines       23221    23225       +4     
  Branches     2600     2600              
==========================================
+ Hits        14801    14803       +2     
- Misses       8405     8407       +2     
  Partials       15       15
Impacted Files Coverage Δ
superset/stats_logger.py 62.79% <50%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299e20a...8d9105c. Read the comment docs.

@timifasubaa timifasubaa force-pushed the add_timing_to_statsd branch 2 times, most recently from 9107a64 to d7b428f Compare September 10, 2018 07:14
@timifasubaa timifasubaa merged commit e35bfba into apache:master Sep 10, 2018
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 11, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants