[refactor] Remove dependency on personal fork of supercluster from mapbox visualizations #5902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtinec
changed the title
| @@ -124,7 +124,7 @@ | |||
| "shortid": "^2.2.6", | |||
| "sprintf-js": "^1.1.1", | |||
| "srcdoc-polyfill": "^1.0.0", | |||
| "supercluster": "https://github.com/georgeke/supercluster/tarball/ac3492737e7ce98e07af679623aad452373bbc40", | |||
| "supercluster": "^4.1.1", | |||
| dotRadius={pointRadius} | ||
| pointRadiusUnit={pointRadiusUnit} | ||
| rgb={rgb} | ||
| globalOpacity={globalOpacity} | ||
| compositeOperation={'screen'} | ||
| renderWhileDragging={renderWhileDragging} | ||
| aggregatorName={aggregatorName} | ||
| aggregation={customMetric ? aggregatorName : undefined} |
There was a problem hiding this comment.
NIT: I think we generally prefer null over undefined though effectively it's the same
There was a problem hiding this comment.
Yep, can change this to null.
superset/viz.py
Outdated
| @@ -1960,7 +1960,7 @@ def get_data(self, df): | |||
| return None | |||
| fd = self.form_data | |||
| label_col = fd.get('mapbox_label') | |||
| custom_metric = label_col and len(label_col) >= 1 | |||
| custom_metric = bool(label_col) and len(label_col) >= 1 | |||
There was a problem hiding this comment.
[optional] we typically don't cast to bool in python, (direct checks on whether a value is truthy are common), but I can see where it's coming from.
There was a problem hiding this comment.
custom_metric is serialized and sent to the client and then used to determine how to cluster the incoming data. Without this change, we get [] when using the default point count for aggregation and true when using a particular column (e.g. population). The client code is more readable when we send a proper boolean as custom_metric. I would probably rename this field to has_custom_metric to reflect its type.
Perhaps I should use not label_col here to produce a boolean for the client to consume?
| }); | ||
| opts.reduce = (accu, prop) => { | ||
| // Temporarily disable param-reassignment linting to work with supercluster's api | ||
| /* eslint-disable no-param-reassign */ |
There was a problem hiding this comment.
[non actionable] interesting related conversation:
eslint/eslint#8581
…pbox visualizations - Update dependency to reference the vanilla supercluster - Clean up backend api call for mapbox vizzes to ensure a boolean is sent to indicate whether the viz includes custom metric for clustering - Refactor of mapbox and its cluster overlay components to use vanilla supercluster and its recommeded way for handling clustering based on custom aggregations. - Allow reclustering within the initial bounds on render in mapbox visualizations (stay true to old behaviors). - Remove the median aggregation from available cluster label aggregators as there is no memory efficient way to implement this and it is unknown how often this feature is used - Updating doc to mention the backward incompatible change re median
… a boolean and rename the field reflect it is a boolean.
xtinec
force-pushed
the
xtinec/use-mapbox-supercluster
branch
from
d9d4066
to
55a1955
Compare
|
LGTM |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…pbox visualizations (apache#5902) * [refactor] Remove dependency to personal fork of supercluster from mapbox visualizations - Update dependency to reference the vanilla supercluster - Clean up backend api call for mapbox vizzes to ensure a boolean is sent to indicate whether the viz includes custom metric for clustering - Refactor of mapbox and its cluster overlay components to use vanilla supercluster and its recommeded way for handling clustering based on custom aggregations. - Allow reclustering within the initial bounds on render in mapbox visualizations (stay true to old behaviors). - Remove the median aggregation from available cluster label aggregators as there is no memory efficient way to implement this and it is unknown how often this feature is used - Updating doc to mention the backward incompatible change re median * Perform the check for has_custom_metric through `not None` to produce a boolean and rename the field reflect it is a boolean.
mistercrunch
added
🏷️ bot
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch @betodealmeida @youngyjd @kristw