[react16] fix React type checking #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now.
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now.
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
Somehow checking the type of a JSX-defined React component is not straightforward and changes through versions of React. Using the `name` attr addresses the issue for now. (cherry picked from commit 9c486a3)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow checking the type of a JSX-defined React component is not
straightforward and changes through versions of React.
Using the
nameattr addresses the issue for now.