Remove lodash.throttle and replace underscore calls with lodash #5946
Conversation
kristw
force-pushed
the
kristw-throttle
branch
2 times, most recently
from
aa56827
to
37d4d27
Compare
kristw
force-pushed
the
kristw-throttle
branch
from
37d4d27
to
48f683b
Compare
Codecov Report
@@ Coverage Diff @@
## master #5946 +/- ##
==========================================
- Coverage 63.58% 63.56% -0.02%
==========================================
Files 393 393
Lines 23674 23661 -13
Branches 2639 2639
==========================================
- Hits 15053 15041 -12
+ Misses 8608 8607 -1
Partials 13 13
Continue to review full report at Codecov.
|
| @@ -10,12 +9,6 @@ import { | |||
| } from '../../../src/modules/utils'; | |||
|
|
|||
| describe('utils', () => { | |||
| it('slugify slugifies', () => { | |||
There was a problem hiding this comment.
can we still rewrite but keep this test case?
There was a problem hiding this comment.
I tested stubbing Superset's slugify implementation with kebabCase from lodash and it passes all test cases under this it except one.
kebabCase: "camelCase" => "camel-case"
slugify: "camelCase" => "camelcase"
This was the only difference. IMO, I am leaning towards switching to lodash's kebabCase which is well-tested library and industry standard than custom implementation and then remove slugify from codebase.
I checked where the function slugify is being used and it is used for creating tooltip id string. My understanding is this is harmless change, so I made the move for it. Please correct me if I misunderstood.
There was a problem hiding this comment.
it used in creating customized url. for example /superset/dashboard/homesmetrics/.
can you make sure existed slugged dashboard url work?
There was a problem hiding this comment.
i think url is generated by python slugify function...so this JS version is just "tooltip". so it really didn't matter much.
|
Thank you. Please merge when you are ready. |
…he#5946) * remove lodash.throttle from dependency * add babel-plugin-lodash' * use lodash instead of underscore for isFunction * switch underscore to lodash * switch from underscore to lodash flatten * Remove slugify and use kebabCase from lodash instead
mistercrunch
added
🏷️ bot
lodash.throttlefrom dependency since there is nowlodash.babel-plugin-lodashthat helps optimize bundle output by taking only necessary part from lodash instead of the entire bundle.https://github.com/lodash/babel-plugin-lodash
underscorecalls withlodashwhere applicable.@williaster @xtinec @conglei