Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #5991 #6035

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Oct 4, 2018

#5991 caused CI tests failed for a few days.

@arpit-agarwal
@michellethomas @williaster @mistercrunch

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #6035 into master will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6035      +/-   ##
=========================================
+ Coverage   64.63%   64.7%   +0.07%     
=========================================
  Files         449     448       -1     
  Lines       23823   23773      -50     
  Branches     2639    2639              
=========================================
- Hits        15398   15383      -15     
+ Misses       8412    8377      -35     
  Partials       13      13
Impacted Files Coverage Δ
superset/cli.py 53.6% <ø> (+3.6%) ⬆️
superset/views/core.py 73.74% <0%> (-0.38%) ⬇️
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e12d00a...96d6234. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit a9ef0ae into apache:master Oct 4, 2018
@graceguo-supercat graceguo-supercat deleted the gg-Revert5991 branch October 4, 2018 20:46
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants