Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ownership before a slice is deleted #624

Merged
merged 1 commit into from
Jun 15, 2016
Merged

Check ownership before a slice is deleted #624

merged 1 commit into from
Jun 15, 2016

Conversation

x4base
Copy link
Contributor

@x4base x4base commented Jun 15, 2016

Only the owner can update the slice, so I think it makes sense to only allow the owner to delete the slices as well.

@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 81.941% when pulling da30b28 on x4base:check_own_on_delete into a117498 on airbnb:master.

@mistercrunch mistercrunch merged commit 65d9feb into apache:master Jun 15, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@mistercrunch @zhaoyongjie
fix: got one color wrong when copy pasting (apache#624)
7ee5bd3
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@mistercrunch @zhaoyongjie
fix: got one color wrong when copy pasting (apache#624)
259a74c
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@mistercrunch @zhaoyongjie
fix: got one color wrong when copy pasting (apache#624)
c844d22
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch @zhaoyongjie
fix: got one color wrong when copy pasting (apache#624)
2a28128
@snyk-bot snyk-bot mentioned this pull request Mar 26, 2022
Closed
@laxmanraparthi laxmanraparthi mentioned this pull request Jun 28, 2023
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0 labels Feb 19, 2024
@laxmanraparthi laxmanraparthi mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x4base @coveralls @mistercrunch