Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent potential db upgrading problem #628

Merged
merged 4 commits into from
Jun 17, 2016
Merged

Prevent potential db upgrading problem #628

merged 4 commits into from
Jun 17, 2016

Conversation

yxjames
Copy link
Contributor

@yxjames yxjames commented Jun 15, 2016

This PR can fix issue #548 . The issue says since the migration happens outside of the app context, using models.Slice to upgrade may produce exception.
Using a mockup declarative sqla models class instead of the class in models.py can avoid the conflict caused by inconsistent context in db.
Idea from here

@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 81.962% when pulling 01e99ba on joshwalters:db_migration into aa2b8b4 on airbnb:master.

@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 81.962% when pulling 01e99ba on joshwalters:db_migration into aa2b8b4 on airbnb:master.

@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 81.941% when pulling 8b4b54e on joshwalters:db_migration into 65d9feb on airbnb:master.

@mistercrunch mistercrunch merged commit 4c8523e into apache:master Jun 17, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@ktmud @zhaoyongjie
chore(legacy-plugin-chart-country-map): use peerDependencies (apache#628
8650465 
)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@ktmud @zhaoyongjie
chore(legacy-plugin-chart-country-map): use peerDependencies (apache#628
dccb9e7 
)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@ktmud @zhaoyongjie
chore(legacy-plugin-chart-country-map): use peerDependencies (apache#628
ee3607a 
)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@ktmud @zhaoyongjie
chore(legacy-plugin-chart-country-map): use peerDependencies (apache#628
45d57b7 
)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yxjames @coveralls @mistercrunch @axeisghost