Fix line chart overflowing the right side #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
added
!deprecated-label:bug
williaster
approved these changes
Feb 7, 2019
|
Maybe I should update the |
| if (staggerLabels) { | ||
| margins.bottom = 40; | ||
| } else { | ||
| if (xLabelRotation === 45) { |
There was a problem hiding this comment.
@kristw what was the problem with the code? I thought that since xLabelRotation and staggerLabels are mutually exclusive we could check for stagger labels first. And if no rotation is set (ie, xLabelRotation = 0) then lines 647-651 would have no effect since we now compute the margins based on the angle.
There was a problem hiding this comment.
Short ans: I changed and it fixes the issue with line chart.
Longer ans: There are other code that modify margins.right above, which will be overridden by your else clause.
graceguo-supercat
pushed a commit
that referenced
this pull request
Feb 8, 2019
* Fix line chart overflowing the right side * revert package-lock.json * revert again (cherry picked from commit 823555e)
xtinec
pushed a commit
that referenced
this pull request
Feb 8, 2019
* Fix line chart overflowing the right side * revert package-lock.json * revert again (cherry picked from commit 823555e)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Fix line chart overflowing the right side * revert package-lock.json * revert again (cherry picked from commit 3f3b7bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect margin calculation for line chart making the content overflow right side.
Fix bug introduced by #6626
@betodealmeida @williaster @graceguo-supercat