Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom control overrides #6956

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions superset/assets/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions superset/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@
"typescript": "^3.1.3",
"url-loader": "^1.0.1",
"webpack": "^4.19.0",
"webpack-merge": "^4.2.1",
michellethomas marked this conversation as resolved.
Show resolved Hide resolved
"webpack-assets-manifest": "^3.0.1",
"webpack-bundle-analyzer": "^3.0.2",
"webpack-cli": "^3.1.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,14 @@ export default class MetricsControl extends React.PureComponent {

componentWillReceiveProps(nextProps) {
if (
isEqual(this.props.columns) !== isEqual(nextProps.columns) ||
isEqual(this.props.savedMetrics) !== isEqual(nextProps.savedMetrics)
!isEqual(this.props.columns, nextProps.columns) ||
!isEqual(this.props.savedMetrics, nextProps.savedMetrics)
) {
this.setState({ options: this.optionsForSelect(nextProps) });
this.props.onChange([]);
// Remove metrics if selected value no longer a column
if (nextProps.columns.indexOf(this.state.value) >= 0) {
this.props.onChange([]);
}
}
if (this.props.value !== nextProps.value) {
this.setState({ value: coerceAdhocMetrics(nextProps.value) });
Expand Down
22 changes: 22 additions & 0 deletions superset/assets/src/explore/controlPanels/extraOverrides.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
// For individual deployments to add custom overrides
export default function extraOverrides(controlPanelConfigs) {
return controlPanelConfigs;
}
5 changes: 3 additions & 2 deletions superset/assets/src/explore/controlPanels/index.js