[filter_box] allow empty filters list (#7220) #7244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases, people want a time filter only on filter box, without specifying dimensions (filters), this allows that (cherry picked from commit e39b169)
michellethomas
added
!deprecated-label:bug
john-bodley
approved these changes
Apr 8, 2019
michellethomas
added a commit
that referenced
this pull request
Apr 8, 2019
cccs-RyanK
added a commit
to CybercentreCanada/superset
that referenced
this pull request
Jun 4, 2024
…ome cases, people want a time filter only on filter box, withoutspecifying dimensions (filters), this allows that(cherry picked from commit e39b169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases, people want a time filter only on filter box, without
specifying dimensions (filters), this allows that
(cherry picked from commit e39b169)
SUMMARY
Cherry picking fix that got into lyftga and we need in 0.31. Time only filters do not work because filter box requires filters.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Check that filter box can have only time filters
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch @john-bodley @graceguo-supercat