fix: time series table (#7302) #7312
Merged
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: time series table * fix: add default value for label * fix: use prop values if defined * fix: revert CollectionControl changes (cherry picked from commit 5dab983)
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #7312 +/- ##
=======================================
Coverage 64.93% 64.93%
=======================================
Files 424 424
Lines 20589 20589
Branches 2281 2281
=======================================
Hits 13369 13369
Misses 7097 7097
Partials 123 123
Continue to review full report at Codecov.
|
michellethomas
added a commit
that referenced
this pull request
Apr 17, 2019
michellethomas
added a commit
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: time series table
fix: add default value for label
fix: use prop values if defined
fix: revert CollectionControl changes
(cherry picked from commit 5dab983)
CATEGORY
Choose one
SUMMARY
Cherry picking fix for time series table into master from lyftga. Again not sure if this is the ideal way to do get this in but we need this in master after reverting the previous fix (I added the previous fix onto 0.31 and now need to add the revert along with this PR).
Previously adding columns to time series table would not work.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Create a time series table
Add a new time series column
ADDITIONAL INFORMATION
REVIEWERS
@khtruong @mistercrunch @john-bodley @graceguo-supercat