Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add header tooltip #7497

Closed
wants to merge 20 commits into from
Closed

Conversation

khtruong
Copy link
Contributor

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Long header titles are elided. To help users see the full header title, tooltips have been added.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2019-05-13 at 10 18 20 AM

TEST PLAN

Tested manually

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@betodealmeida @DiggidyDave @xtinec @datability-io

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #7497 into lyft-release-sp8 will increase coverage by 0.06%.
The diff coverage is 50%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           lyft-release-sp8   #7497      +/-   ##
===================================================
+ Coverage             65.13%   65.2%   +0.06%     
===================================================
  Files                   435     435              
  Lines                 21414   21414              
  Branches               2361    2361              
===================================================
+ Hits                  13948   13962      +14     
+ Misses                 7346    7332      -14     
  Partials                120     120
Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.jsx 91.01% <50%> (ø) ⬆️
superset/views/core.py 72.99% <0%> (+0.2%) ⬆️
superset/models/core.py 83.46% <0%> (+0.45%) ⬆️
superset/db_engine_specs.py 61.47% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f8f27...f449868. Read the comment docs.

@khtruong khtruong changed the base branch from lyft-release-sp8 to lyft-develop May 16, 2019 21:47
@khtruong khtruong changed the base branch from lyft-develop to lyft-release-sp8 May 16, 2019 21:49
@khtruong
Copy link
Contributor Author

Opened new PR #7531 because these changes need to be checked into lyft-develop now.

@khtruong khtruong closed this May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants