fix: SqlaColumn.type overflow on mysql #7606
Merged
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hitting a new error when loading examples around a datatype that exceeds the 32 chars limit on SqlaColumn.type Type includes the 'COLLATE utf8mb4_general_ci' suffix which is too verbose and not needed in that context.
mistercrunch
force-pushed
the
fix_collate
branch
3 times, most recently
from
a900b06 to
f0b75be
Compare
Codecov Report
@@ Coverage Diff @@
## master #7606 +/- ##
========================================
Coverage ? 65.6%
========================================
Files ? 435
Lines ? 21704
Branches ? 2387
========================================
Hits ? 14239
Misses ? 7344
Partials ? 121
Continue to review full report at Codecov.
|
villebro
requested changes
Jun 2, 2019
villebro
approved these changes
Jun 3, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Future proofing for
mysqlclient>=1.4, as extracting column types becomes more verbose and overflows our 32 char liimit onSqlaColumn.typeType looks like 'VARCHAR(255) COLLATE utf8mb4_general_ci' suffix which is too
verbose and not needed in that context. Adding mysql-specific code that strips out the collation information.