Revert "Allow bigint to be used as time column in Presto" #7670 #7678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #7218 (comment) including a
BIGINT
column type as a time column in Presto is problematic as it could represent either a Unix time in seconds or milliseconds.The current correct way to handle Unix time columns is to set the
python_date_format
as eitherepoch
orepoch_ms
(depending on the encoding) which results in queries comprising the correct fidelity:Note #7656 plans to auto-detect the encoding of temporal columns.
to: @betodealmeida @mistercrunch