Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Fix docker-init missing FLASK_APP #7709

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 14, 2019

CATEGORY

Choose one

  • Bug Fix

SUMMARY

New flask fab ... cli needs FLASK_APP env var to be set

TEST PLAN

Run:
docker-compose build
docker-compose run --rm superset ./docker-init.sh

ADDITIONAL INFORMATION

@codecov-io
Copy link

Codecov Report

Merging #7709 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7709   +/-   ##
=======================================
  Coverage   65.76%   65.76%           
=======================================
  Files         459      459           
  Lines       21909    21909           
  Branches     2408     2408           
=======================================
  Hits        14409    14409           
  Misses       7379     7379           
  Partials      121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d12243...2fefed7. Read the comment docs.

@dpgaspar dpgaspar changed the title [docker] Fix docker-init missing FLASK_APP [docker] Fix docker-init missing FLASK_APP #7707 Jun 14, 2019
@dpgaspar dpgaspar changed the title [docker] Fix docker-init missing FLASK_APP #7707 [docker] Fix docker-init missing FLASK_APP Jun 14, 2019
@mistercrunch mistercrunch merged commit b6ab691 into apache:master Jun 14, 2019
@mistercrunch mistercrunch deleted the fix/docker-compose-init branch June 14, 2019 16:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants