[WiP] Introduce uuids to power ImportExportMixin #7829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exports/imports will work better if we generate and use UUIDs as a basis for upserting objects.
villebro
requested changes
Jul 9, 2019
| """Add a uuid column to a given table""" | ||
| print(f"Add uuid column to table '{tbl_name}'") | ||
| with op.batch_alter_table(tbl_name) as batch_op: | ||
| batch_op.add_column(Column("uuid", CHAR(36), default=get_uuid)) |
There was a problem hiding this comment.
I would suggest using UUIDType from SQLAlchemy-Utils, as it will automatically leverage native UUID support where available (falls back to BINARY(16) or CHAR(32) where not available). This will introduce a new dependency, but the project is actively maintained, of high quality in my experience, and the license should be ok (BSD).
|
|
||
|
|
||
| def get_uuid(): | ||
| return str(uuid.uuid4()) |
There was a problem hiding this comment.
If we opt to use UUIDType, this shouldn't need to be cast to str (I believe).
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
This was referenced Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP!