Make package.json cross platform

[fzzylogic]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

Make package.json cross platform (so besides Linux and Mac, it will work on Windows with cmd or powershell without modifications). Tested on Linux and Windows. Though webpack builds successfully on windows, the minified output is different.

Attempt at redemption after #8024 ^^

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

etr2460

[etr2460]

since you're adding a new dependency, you need to run npm install and commit the lockfile changes as well

[kristw]

Also, what about other commands other than build?

[etr2460]

Also, what about other commands other than build?

It looks like build is the only command that sets an env variable, so i assume all the others work cross platform already

[codecov-io]

Codecov Report

Merging #8035 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8035      +/-   ##
==========================================
+ Coverage   65.54%   65.54%   +<.01%     
==========================================
  Files         469      469              
  Lines       22475    22487      +12     
  Branches     2440     2446       +6     
==========================================
+ Hits        14731    14739       +8     
- Misses       7624     7628       +4     
  Partials      120      120

Impacted Files	Coverage Δ
superset/db_engine_specs/sqlite.py	45.83% <0%> (-20.84%)	⬇️
superset/utils/core.py	87.66% <0%> (-0.17%)	⬇️
superset/db_engine_specs/presto.py	77.98% <0%> (-0.09%)	⬇️
superset/viz.py	71.58% <0%> (-0.03%)	⬇️
superset/assets/src/chart/ChartRenderer.jsx	8.06% <0%> (ø)	⬆️
...src/SqlLab/utils/reduxStateToLocalStorageHelper.js	100% <0%> (ø)	⬆️
superset/config.py	88.7% <0%> (ø)	⬆️
superset/assets/src/SqlLab/reducers/sqlLab.js	48.38% <0%> (ø)	⬆️
...et/assets/src/dashboard/components/SliceHeader.jsx	24% <0%> (ø)	⬆️
superset/examples/deck.py	11.11% <0%> (ø)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5375745...497934f. Read the comment docs.

[fzzylogic]

Introduced "response": "" instead of "response": false in package-lock in some cases accidentally, resolved with last commit. @etr2460 thanks for the guidance, @kristw yes, cross-env only solves the env var problem, however i didn't test all the other commands on Windows. Thanks!

[etr2460]

lgtm, thanks for this!