-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iran to Country Visualization #8940
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8940 +/- ##
=======================================
Coverage 59.08% 59.08%
=======================================
Files 374 374
Lines 12205 12205
Branches 2989 2989
=======================================
Hits 7211 7211
Misses 4815 4815
Partials 179 179
Continue to review full report at Codecov.
|
It looks like many countries are missing from this list. Would you mind adding all of the missing countries? |
@robdiciuccio looks like this has a corresponding pr apache-superset/superset-ui-plugins#306 that includes the geojson file for this country. Adding all the missing countries may be a significant amount of work |
My PR in superset-ui is merged now. I think you can merge this. I don't know should I increase superset-ui-plugins package version or no. |
@mistercrunch Is it ok to merge? |
Any comments on this PR? |
@ali-bahjati can you rebase? There's a conflict on |
@villebro Done. |
Thanks @ali-bahjati ! |
This PR Requires This superset-ui-plugins PR to be merged first.