Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iran to Country Visualization #8940

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Conversation

ali-bahjati
Copy link
Contributor

  • Enhancement (new features, refinement)

This PR Requires This superset-ui-plugins PR to be merged first.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #8940 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8940   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files         374      374           
  Lines       12205    12205           
  Branches     2989     2989           
=======================================
  Hits         7211     7211           
  Misses       4815     4815           
  Partials      179      179           
Impacted Files Coverage Δ
superset-frontend/src/explore/controls.jsx 40.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36a7e3...c76993a. Read the comment docs.

@robdiciuccio
Copy link
Member

It looks like many countries are missing from this list. Would you mind adding all of the missing countries?

@nytai
Copy link
Member

nytai commented Jan 13, 2020

@robdiciuccio looks like this has a corresponding pr apache-superset/superset-ui-plugins#306 that includes the geojson file for this country. Adding all the missing countries may be a significant amount of work

@ali-bahjati
Copy link
Contributor Author

My PR in superset-ui is merged now. I think you can merge this. I don't know should I increase superset-ui-plugins package version or no.

@ali-bahjati
Copy link
Contributor Author

@mistercrunch Is it ok to merge?

@ali-bahjati
Copy link
Contributor Author

Any comments on this PR?

@villebro
Copy link
Member

@ali-bahjati can you rebase? There's a conflict on controls.jsx that's blocking merging

@ali-bahjati
Copy link
Contributor Author

@villebro Done.

@villebro
Copy link
Member

Thanks @ali-bahjati !

@villebro villebro merged commit 98ac720 into apache:master Mar 18, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants