Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict werkzeug to <1.0 in setup.py #9111

Closed
wants to merge 1 commit into from
Closed

fix: restrict werkzeug to <1.0 in setup.py #9111

wants to merge 1 commit into from

Conversation

villebro
Copy link
Member

@villebro villebro commented Feb 10, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

With the release of werkzeug 1.0.0, installing via pip pulls in a version of werkzeug which is not currently compatible with superset. This PR restricts the version of werkzeug to <1.0 in setup.py, ensuring that installation via pip works properly.

TEST PLAN

Test locally

ADDITIONAL INFORMATION

@codecov-io
Copy link

Codecov Report

Merging #9111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9111   +/-   ##
======================================
  Coverage    59.1%   59.1%           
======================================
  Files         372     372           
  Lines       11920   11920           
  Branches     2917    2917           
======================================
  Hits         7045    7045           
  Misses       4693    4693           
  Partials      182     182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2913063...c20a25e. Read the comment docs.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this on FAB, I've just release 2.2.3rc6 with flask-babel>1 (currently running tests), I'll make a final release and submit a PR here

@villebro
Copy link
Member Author

Closing as there is a cleaner way to fix this.

@villebro villebro closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall
3 participants