[docker] fix, Dockerfile for frontend builds

[suddjian]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

My previous PR introduced a bug to the Dockerfile. This fixes it by copying build frontend files to/from the right places.

TEST PLAN

I've verified this by running docker-compose up --build, but again would appreciate verification from someone better versed in docker-ology

ADDITIONAL INFORMATION

• Has associated issue: Fixes Superset-node docker compose fails to create container #9112
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@mistercrunch @nytai

[codecov-io]

Codecov Report

Merging #9114 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #9114      +/-   ##
=========================================
- Coverage    59.1%   59.1%   -0.01%     
=========================================
  Files         372     372              
  Lines       11920   11922       +2     
  Branches     2917    2919       +2     
=========================================
+ Hits         7045    7046       +1     
- Misses       4693    4694       +1     
  Partials      182     182

Impacted Files	Coverage Δ
superset-frontend/src/chart/chartAction.js	43.33% <0%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2913063...9bc622a. Read the comment docs.

[nytai]

👍

[nytai]

actually getting:
ERROR: Service 'superset' failed to build: COPY failed: stat /var/lib/docker/overlay2/da84b52e48a6b3377e530754d4fd271917761b201d64bc3a77d4e8574971ba62/merged/app/superset-frontend/version_info.json: no such file or directory when running locally

[nytai]

Looks like version_info.json is produced by running setup.py. I think it's only meant to end up in the actual pip tarball package under superset/static/assets/version_info.json. Looking at setup.py I'm not sure the paths are correct for generating version_info.json.

[suddjian]

I think you're right, thanks for catching that @nytai

[suddjian]

Whew. Had some trials and tribulations as you can see from the commit log but I dare say this is ready to go. Approvals/criticisms welcome.

One change I was forced to make was moving version_info.json from /static/assets to /static. Issues arose around it being built by python code while webpack owns the contents of /assets. version_info isn't really an asset anyway, so I would argue that /static is a more correct location for it in this directory structure.

[nytai]

👍

[nytai]

should also fix #9108, #9116

[dpgaspar]

Looks good, needs a possible change

[dpgaspar]

Gave it a quick run and looks good