Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-36] Update CONTRIBUTING with TypeScript details #9185

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Feb 21, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Updates CONTRIBUTING.md with the details agreed upon in SIP-36

TEST PLAN

CI

ADDITIONAL INFORMATION

REVIEWERS

to: @nytai @graceguo-supercat @kristw @rusackas

- [Testing](#testing)
- [JavaScript testing](#javascript-testing)
- [Integration testing](#integration-testing)
- [Contributing](#contributing)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated table of contents from the headers in this file

@codecov-io
Copy link

Codecov Report

Merging #9185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9185   +/-   ##
=======================================
  Coverage   59.13%   59.13%           
=======================================
  Files         372      372           
  Lines       11938    11938           
  Branches     2925     2925           
=======================================
  Hits         7059     7059           
  Misses       4699     4699           
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efdfc5...83ba3a3. Read the comment docs.

Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for the additional docs.

@kristw kristw merged commit 5ba7fca into apache:master Feb 24, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants