Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate metric from bullet chart #9274

Merged
merged 1 commit into from
Mar 11, 2020
Merged

fix: remove duplicate metric from bullet chart #9274

merged 1 commit into from
Mar 11, 2020

Conversation

villebro
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

In the Bullet Chart control panel, metric is defined twice, causing a weird user experience and duplicated metrics in the viz request payload.

BEFORE

image

AFTER

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

Codecov Report

Merging #9274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9274   +/-   ##
======================================
  Coverage    58.9%   58.9%           
======================================
  Files         373     373           
  Lines       12026   12026           
  Branches     2953    2953           
======================================
  Hits         7084    7084           
  Misses       4763    4763           
  Partials      179     179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724b8a3...0004470. Read the comment docs.

@villebro villebro merged commit 406ad87 into apache:master Mar 11, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.36 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants