-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump click in setup.py and requirements.txt #9299
Conversation
The reason it was pinned is because click>=7 forces dashes in subcommands ie It's better but disruptive... Will break dockers and helm charts everywhere. I wonder if there's a way to support both with click>=7 |
Nice solution to support both fresh as of 19 days ago! pallets/click#1123 (comment) |
Thanks for this @mistercrunch , I'll update accordingly! |
Codecov Report
@@ Coverage Diff @@
## master #9299 +/- ##
==========================================
+ Coverage 58.9% 58.93% +0.03%
==========================================
Files 373 373
Lines 12026 12033 +7
Branches 2953 2955 +2
==========================================
+ Hits 7084 7092 +8
+ Misses 4763 4762 -1
Partials 179 179
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not a big fan of keeping the _
but totally understand, for the sake of stability.
I propose to remove this on 1.0.0
Perhaps we should add a TODO to keep track of stuff that will get refactored for 1.0? |
CATEGORY
Choose one
SUMMARY
As of #9277 ,
pip-tools
was bumped to4.5.1
, which requiresclick>=7
: link. This is currently at odds withsetup.py
, which requiresclick<7.0.0
. This PR bumps click to the latest version, which seems to work well with Superset.TEST PLAN
Tested locally + CI
REVIEWERS
@john-bodley