Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add datasource metrics to point size dropdown in deckgl scatterplot viz #9309

Merged
merged 1 commit into from
Mar 16, 2020
Merged

fix: add datasource metrics to point size dropdown in deckgl scatterplot viz #9309

merged 1 commit into from
Mar 16, 2020

Conversation

villebro
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Currently the FixedOrMetricControl that is used in the DeckGL Scatterplot viz is missing saved metrics.

BEFORE

image

AFTER

image

TEST PLAN

Tested locally.

REVIEWERS

@kristw @rusackas @etr2460 @mistercrunch

etr2460
etr2460 approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, lgtm

@villebro villebro merged commit f1370c5 into apache:master Mar 16, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villebro @mistercrunch @etr2460