-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: big number to handle NULL as it did in the past #9314
fix: big number to handle NULL as it did in the past #9314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a unit test to this PR as this was a regression that was recently introduced?
I can write a unit test covering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I think i'd feel comfortable accepting then once you add the manual test plan and some screenshots
however, a unit test should fast follow
I'm working on a unit test for this PR now. |
@etr2460 unfortunately I was unable to come up with a comprehensive unit test by the end of my day. This will have to wait for @mistercrunch to free up again this evening. Apologies. |
0d159a7
to
06eb8ea
Compare
Definitely was worth taking the time to write the unit test. Pandas is doing some funky things here in Anyhow. This here works, I picked |
Codecov Report
@@ Coverage Diff @@
## master #9314 +/- ##
=======================================
Coverage 59.08% 59.08%
=======================================
Files 374 374
Lines 12205 12205
Branches 2989 2989
=======================================
Hits 7211 7211
Misses 4815 4815
Partials 179 179 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me, thanks for adding the unit test!
I appreciate the quick response to the regression called out in the revert PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, LGTM. It seems one really has to be careful when applying Pandas transformations.
@mistercrunch is this good to merge now? |
context: #9313