Catch db_engine_spec.get_function_names exceptions

[bkyryliuk]

CATEGORY

Choose one

• Bug Fix

SUMMARY

Short term fix for the #9678
Databases api fetches all database function names, it requires the databases to be online and return the values successfully to be able to fetch the list of the databases.
If it fails sqllab is not able to get the list of the databases and becomes disfunctional

TEST PLAN

tested on the dropbox staging environment, provided bad DB url and made sure that sqllab works.

ADDITIONAL INFORMATION

• Has associated issue:

REVIEWERS

@villebro @dpgaspar

[codecov-io]

Codecov Report

Merging #9691 into master will decrease coverage by 12.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #9691       +/-   ##
===========================================
- Coverage   65.80%   53.57%   -12.23%     
===========================================
  Files         581      350      -231     
  Lines       30323    11202    -19121     
  Branches     3095     2775      -320     
===========================================
- Hits        19953     6002    -13951     
+ Misses      10189     5017     -5172     
- Partials      181      183        +2     

Flag	Coverage Δ
#cypress	53.57% <ø> (?)
#javascript	?
#python	?

Impacted Files	Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js	0.00% <0.00%> (-100.00%)	⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js	0.00% <0.00%> (-93.19%)	⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx	11.76% <0.00%> (-88.24%)	⬇️
...c/explore/components/controls/withVerification.jsx	9.09% <0.00%> (-87.88%)	⬇️
...src/dashboard/components/gridComponents/Header.jsx	10.52% <0.00%> (-86.85%)	⬇️
...rc/dashboard/components/gridComponents/Divider.jsx	13.33% <0.00%> (-86.67%)	⬇️
...c/dashboard/components/gridComponents/Markdown.jsx	6.59% <0.00%> (-82.42%)	⬇️
...uperset-frontend/src/utils/getClientErrorObject.js	0.00% <0.00%> (-80.00%)	⬇️
superset-frontend/src/components/Link.tsx	7.69% <0.00%> (-79.81%)	⬇️
...et-frontend/src/SqlLab/components/TableElement.jsx	4.59% <0.00%> (-78.17%)	⬇️
... and 446 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a15f0...3ec7d01. Read the comment docs.

[bkyryliuk]

github checks somehow did not rerun when the commit was amended, still shows old code here:

[bkyryliuk]

@dpgaspar, @villebro or @etr2460 could someone merge it, I am still waiting on getting the merge rights :(

[dpgaspar]

merging, sorry for the delay