Query the new chart data api for charts that support it #9710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9710 +/- ##
==========================================
- Coverage 70.78% 66.02% -4.77%
==========================================
Files 586 586
Lines 30434 30445 +11
Branches 3117 3121 +4
==========================================
- Hits 21544 20101 -1443
- Misses 8776 10160 +1384
- Partials 114 184 +70
Continue to review full report at Codecov.
|
villebro
reviewed
May 7, 2020
| @@ -84,7 +84,7 @@ | |||
| "@superset-ui/legacy-plugin-chart-sunburst": "^0.13.5", | |||
| "@superset-ui/legacy-plugin-chart-table": "^0.13.5", | |||
| "@superset-ui/legacy-plugin-chart-treemap": "^0.13.3", | |||
| "@superset-ui/legacy-plugin-chart-world-map": "^0.13.3", | |||
| "@superset-ui/legacy-plugin-chart-world-map": "^0.13.6", | |||
There was a problem hiding this comment.
We also need to bump @superset-ui/plugin-chart-word-cloud to 0.13.5
12 tasks
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Charts with the metadata value
useLegacyApiset tofalsewill now query the new api endpoint. This is demonstrated with the word cloud plugin, which has been upgraded to the non-legacy version.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
I've added a test for the api query, and verified both the new word cloud and a few of the legacy chart types in Explore. Still verifying that charts work correctly in Dashboards. You're encouraged to try out the branch.
ADDITIONAL INFORMATION
REVIEWERS