fix bug where error at import dashboard fails to show toast in "welcome" app

[pkdotson]

CATEGORY

Choose one

• [ x] Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

The toast messages weren't working when there was an error redirect from the import template to the react dashboard component. To fix this common data had to be passed into the components the app level to show toast or not.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

To test out go to import and try to upload a non dashboard. You will be redirected to page to dashboardlist with the correct toast.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

[etr2460]

some comments, but a higher level question too: it seems like we'd want to show these flash messages (if they exist) on any page. Is there a way we can raise this logic up to the App.jsx level instead so that it applies everywhere instead of only on the DashboardList?

[codecov-io]

Codecov Report

Merging #9714 into master will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #9714      +/-   ##
==========================================
- Coverage   70.78%   70.54%   -0.25%     
==========================================
  Files         586      587       +1     
  Lines       30433    30449      +16     
  Branches     3117     3119       +2     
==========================================
- Hits        21543    21481      -62     
- Misses       8776     8847      +71     
- Partials      114      121       +7     

Flag	Coverage Δ
#cypress	52.89% <ø> (-0.75%)	⬇️
#javascript	58.95% <0.00%> (-0.08%)	⬇️
#python	70.93% <ø> (ø)

Impacted Files	Coverage Δ
superset-frontend/src/components/FlashProvider.tsx	0.00% <0.00%> (ø)
...frontend/src/views/dashboardList/DashboardList.tsx	63.70% <ø> (ø)
superset-frontend/src/welcome/App.jsx	0.00% <0.00%> (ø)
...et-frontend/src/SqlLab/reducers/getInitialState.js	33.33% <0.00%> (-16.67%)	⬇️
superset-frontend/src/reduxUtils.js	76.47% <0.00%> (-10.30%)	⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx	75.52% <0.00%> (-6.30%)	⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js	61.13% <0.00%> (-5.68%)	⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx	44.00% <0.00%> (-4.00%)	⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js	37.44% <0.00%> (-3.30%)	⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx	88.57% <0.00%> (-2.86%)	⬇️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b93bf05...7d42c3d. Read the comment docs.

[etr2460]

lgtm with the exception of a couple remaining nits. Thanks for the contribution!