Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dataset): improve performance on get list #9739

Merged
merged 3 commits into from
May 6, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 5, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Like stated on #9619, when using properties has virtual columns, we should to make sure that the method references columns already referenced on list_columns or SQLAlchemy will issue a new query

Before:
[stats_logger] (timing) DatasetRestApi.get_list.time 110ms - 150ms

After:
[stats_logger] (timing) DatasetRestApi.get_list.time 25ms - 35ms

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #9739 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9739      +/-   ##
==========================================
- Coverage   70.71%   70.48%   -0.24%     
==========================================
  Files         584      402     -182     
  Lines       30388    12564   -17824     
  Branches     3112     3112              
==========================================
- Hits        21490     8856   -12634     
+ Misses       8784     3594    -5190     
  Partials      114      114              
Flag Coverage Δ
#cypress 53.60% <ø> (+0.02%) ⬆️
#javascript 58.90% <ø> (ø)
#python ?
Impacted Files Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx 88.76% <0.00%> (-1.13%) ⬇️
superset/views/log/views.py
superset/models/tags.py
superset/views/database/views.py
superset/dashboards/commands/bulk_delete.py
superset/models/dashboard.py
superset/views/database/decorators.py
superset/db_engine_specs/postgres.py
superset/db_engine_specs/impala.py
superset/examples/country_map.py
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11972ed...c5fbcc8. Read the comment docs.

@dpgaspar dpgaspar marked this pull request as ready for review May 5, 2020 12:38
@dpgaspar dpgaspar merged commit 453806f into apache:master May 6, 2020
@dpgaspar dpgaspar deleted the perf/api-datasets branch May 6, 2020 10:48
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants