Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] hack bootswatch/cosmo theme to get better tabs for sql-lab (and other things) #975

Merged
merged 6 commits into from
Aug 19, 2016
Merged

[ui] hack bootswatch/cosmo theme to get better tabs for sql-lab (and other things) #975

merged 6 commits into from
Aug 19, 2016

Conversation

ascott
Copy link

@ascott ascott commented Aug 18, 2016

  • updates the /caravel/theme page so we have quick reference for our ui styles
  • gets us decent looking tabs for sql-lab
  • removes the paper bootswatch theme
  • use consistent classes on welcome page for consistent styling
  • make search bar bigger on welcome page
  • part of the work for this issue: [ui] do design review tweaks to sql-lab #950

_cosmo-theme

screenshot 2016-08-17 19 31 37

screenshot 2016-08-17 19 31 57

screenshot 2016-08-17 19 32 11

screenshot 2016-08-17 19 32 38

plz review @mistercrunch @bkyryliuk

@mistercrunch
Copy link
Member

Neat! I really appreciate the cleanup of unruly css I had patched up everywhere.

Looks like SQL Lab will only need a few adjustments.
screen shot 2016-08-18 at 8 59 30 am

I think I prefer the more subtle alerts we had before:
screen shot 2016-08-18 at 9 00 27 am

Another thought is that I used the Airbnb color scheme before for all the colors, which I'm not attached to particularly, but had the advantage of matching the visualizations colors (also based on Airbnb colors)

@mistercrunch
Copy link
Member

Also how do we make labels look less like buttons? Rounded?

@ascott
Copy link
Author

ascott commented Aug 18, 2016

good call on lightening up the alert background colors. i'll do that.

i think because we aren't using the other colored buttons, that the labels look like labels and not buttons, especially because of their size. if we are seeing confusion here, we can iterated in another PR.

i'm not too keen on keeping the airbnb color palette in caravel, but i could be convinced otherwise. let's merge this an iterated as needed.

thx for the review @mistercrunch !

@jefffeng
Copy link

nice work Alanna! I really like this new theme. Cleans things up quite a
bit :)

On Thu, Aug 18, 2016 at 9:04 AM, Maxime Beauchemin <notifications@github.com

wrote:

Neat! I really appreciate the cleanup of unruly css I had patched up
everywhere.

Looks like SQL Lab will only need a few adjustments.
[image: screen shot 2016-08-18 at 8 59 30 am]
https://cloud.githubusercontent.com/assets/487433/17780966/24fb5fca-6522-11e6-9dd3-e2caff2d5205.png

I think I prefer the more subtle alerts we had before:
[image: screen shot 2016-08-18 at 9 00 27 am]
https://cloud.githubusercontent.com/assets/487433/17780999/4924e308-6522-11e6-8cb8-ebf66d8cc2be.png

Another thought is that I used the Airbnb color scheme before for all the
colors, which I'm not attached to particularly, but had the advantage of
matching the visualizations colors (also based on Airbnb colors)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#975 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARcz4SkkmXQoKgH2-JanN4k_q-ybaXLWks5qhIKIgaJpZM4JnFXA
.

Jeff Feng
Product Manager
m: (949)-610-5108
twitter: @jtfeng

@ascott
Copy link
Author

ascott commented Aug 19, 2016

update!

cosmo-caravel

forked-cosmo

going to merge once tests pass.

@ascott ascott merged commit 30ef8eb into apache:master Aug 19, 2016
@ascott ascott deleted the ascott-hack-a-theme branch August 19, 2016 06:49
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants