feat: partitionchart controls migration #9768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkdotson
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9768 +/- ##
==========================================
- Coverage 70.89% 64.26% -6.63%
==========================================
Files 585 531 -54
Lines 30427 29079 -1348
Branches 3152 2805 -347
==========================================
- Hits 21572 18689 -2883
- Misses 8744 10212 +1468
- Partials 111 178 +67
Continue to review full report at Codecov.
|
pkdotson
changed the title
pkdotson
force-pushed
the
phillip/SO-264-partitionchart-controls-migration
branch
from
df7c764 to
6606938
Compare
pkdotson
changed the title
rusackas
reviewed
May 15, 2020
superset-frontend/spec/javascripts/components/ColumnOption_spec.jsx
Outdated
Show resolved
Hide resolved
rusackas
approved these changes
May 18, 2020
superset-frontend/spec/javascripts/components/ColumnOption_spec.jsx
Outdated
Show resolved
Hide resolved
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix lint error * fix: import lint error * pull in latests code * delete control from plugin registry * fixing again... * another fix with rebase... * commit change * update packages and fix test * fix: add ignore to lint error * fix mr * fix lint * fix imports Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Remove partition chart and chart dependencies from incubator to superset.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS