fix: reenable table chart page length #9884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522
Codecov Report
@@ Coverage Diff @@
## master #9884 +/- ##
=======================================
Coverage 71.24% 71.24%
=======================================
Files 584 584
Lines 30789 30789
Branches 3234 3234
=======================================
+ Hits 21936 21937 +1
+ Misses 8744 8743 -1
Partials 109 109
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
May 22, 2020
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
May 22, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522 (cherry picked from commit 6d4e236)
pkdotson
pushed a commit
to preset-io/superset
that referenced
this pull request
May 26, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bump @superset-ui/legacy-preset-chart-table to fix missing
page length support.
See apache-superset/superset-ui#522
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Added unit-test in superset-ui.
Manual testing:
ADDITIONAL INFORMATION