Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add workflow preferring TypeScript files #9901

Merged
merged 21 commits into from
Jun 1, 2020
Merged

build: add workflow preferring TypeScript files #9901

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9d29e78
Add workflow preventing non TypeScript Files
May 25, 2020
820d9d2
Create comment_preferring_typescript.md
May 25, 2020
03f9d90
Update prevent_non_typescript_files.yml
May 25, 2020
9f801ad
Update prevent_non_typescript_files.yml
May 25, 2020
400c43a
Update prevent_non_typescript_files.yml
May 25, 2020
7dd027f
Delete comment_preferring_typescript.md
May 25, 2020
b33ac13
Create comment_preferring_typescript.md
May 25, 2020
07f7ece
Delete comment_preferring_typescript.md
May 25, 2020
dc50bb7
Update prevent_non_typescript_files.yml
May 25, 2020
e847e8e
Update prevent_non_typescript_files.yml
May 25, 2020
801a005
Update prevent_non_typescript_files.yml
May 25, 2020
4d8f2cf
Update prevent_non_typescript_files.yml
May 25, 2020
9f8a655
Update prevent_non_typescript_files.yml
May 25, 2020
b330fc3
Update prevent_non_typescript_files.yml
May 25, 2020
6d45eb0
Update prevent_non_typescript_files.yml
May 25, 2020
66f6c1b
Update prevent_non_typescript_files.yml
May 25, 2020
78daf2a
Create test.js
May 25, 2020
c4ce731
Delete test.js
May 25, 2020
58bb3e7
Update prevent_non_typescript_files.yml
May 25, 2020
7555161
Rename prevent_non_typescript_files.yml to prefer_typescript.yml
May 25, 2020
4463234
Update prefer_typescript.yml
May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/prefer_typescript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Prefer TypeScript

on:
pull_request:
branches:
- master

jobs:
comment:
name: Comment about preferring TypeScript
runs-on: ubuntu-latest
steps:
- name: Get changed files
id: changed
uses: trilom/file-changes-action@v1.2.3
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
- name: Determine if a .js or .jsx file was added
id: check
run: |
echo ::set-output name=was_js_file_added::$(jq 'map(endswith(".js") or endswith(".jsx"))' ${HOME}/files_added.json | jq 'reduce .[] as $is_js (false; . or $is_js)')
- if: steps.check.outputs.was_js_file_added != 'false'
name: Comment about preferring TypeScript
uses: unsplash/comment-on-pr@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
msg: |
## WARNING: Prefer TypeScript

It looks like your PR contains new `.js` or `.jsx` files. As decided in [SIP-36](https://github.com/apache/incubator-superset/issues/9101), all new files should be written in TypeScript. Please convert new JavaScript files to TypeScript and then re-request review.