Skip to content

Commit

Permalink
Revert "Adding temporary classes to resolve NoSuchMethodError for Bas…
Browse files Browse the repository at this point in the history
…icSignatureSigningConfiguration.setSigningCredentials"

This reverts commit 6abf7e0.
  • Loading branch information
ilgrosso committed Jul 21, 2023
1 parent 34e4aeb commit 7f600b7
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 291 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,7 @@ public SAML2Client add(
cfg.setServiceProviderEntityId(spEntityID);
getSPMetadataPath(spEntityID).ifPresent(cfg::setServiceProviderMetadataResourceFilepath);

SAML2Client saml2Client = new SAML2Client(cfg) {

@Override
protected void initSignatureSigningParametersProvider() {
signatureSigningParametersProvider = new SAML2SP4UISignatureSigningParametersProvider(configuration);
}
};
SAML2Client saml2Client = new SAML2Client(cfg);
saml2Client.setCallbackUrlResolver(new NoParameterCallbackUrlResolver());
saml2Client.setCallbackUrl(callbackUrl);
saml2Client.init();
Expand Down

This file was deleted.

9 changes: 1 addition & 8 deletions sra/src/main/java/org/apache/syncope/sra/SecurityConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import org.apache.syncope.sra.security.saml2.SAML2MetadataEndpoint;
import org.apache.syncope.sra.security.saml2.SAML2SecurityConfigUtils;
import org.apache.syncope.sra.security.saml2.SAML2WebSsoAuthenticationWebFilter;
import org.apache.syncope.sra.security.saml2.SRASignatureSigningParametersProvider;
import org.bouncycastle.jce.provider.BouncyCastleProvider;
import org.pac4j.core.http.callback.NoParameterCallbackUrlResolver;
import org.pac4j.saml.client.SAML2Client;
Expand Down Expand Up @@ -294,13 +293,7 @@ public InputStream retrieve() throws Exception {

cfg.setSessionLogoutHandler(new NoOpSessionLogoutHandler());

SAML2Client saml2Client = new SAML2Client(cfg) {

@Override
protected void initSignatureSigningParametersProvider() {
signatureSigningParametersProvider = new SRASignatureSigningParametersProvider(configuration);
}
};
SAML2Client saml2Client = new SAML2Client(cfg);
saml2Client.setName(SRAProperties.AMType.SAML2.name());
saml2Client.setCallbackUrl(props.getSaml2().getEntityId()
+ SAML2WebSsoAuthenticationWebFilter.FILTER_PROCESSES_URI);
Expand Down

This file was deleted.

4 changes: 0 additions & 4 deletions wa/starter/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,6 @@ under the License.
<groupId>org.apereo.cas</groupId>
<artifactId>cas-server-support-saml-idp-core</artifactId>
</dependency>
<dependency>
<groupId>org.apereo.cas</groupId>
<artifactId>cas-server-support-saml-idp-web</artifactId>
</dependency>
<dependency>
<groupId>org.apereo.cas</groupId>
<artifactId>cas-server-support-oidc</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
import org.apache.syncope.wa.starter.pac4j.WADelegatedClientFactory;
import org.apache.syncope.wa.starter.pac4j.saml.WASAML2ClientCustomizer;
import org.apache.syncope.wa.starter.saml.idp.WASamlIdPCasEventListener;
import org.apache.syncope.wa.starter.saml.idp.WASamlIdPObjectSigner;
import org.apache.syncope.wa.starter.saml.idp.metadata.WASamlIdPMetadataGenerator;
import org.apache.syncope.wa.starter.saml.idp.metadata.WASamlIdPMetadataLocator;
import org.apache.syncope.wa.starter.services.WAServiceRegistry;
Expand Down Expand Up @@ -97,13 +96,11 @@
import org.apereo.cas.support.saml.idp.metadata.generator.SamlIdPMetadataGeneratorConfigurationContext;
import org.apereo.cas.support.saml.idp.metadata.locator.SamlIdPMetadataLocator;
import org.apereo.cas.support.saml.services.idp.metadata.SamlIdPMetadataDocument;
import org.apereo.cas.support.saml.web.idp.profile.builders.enc.SamlIdPObjectSigner;
import org.apereo.cas.util.DateTimeUtils;
import org.apereo.cas.util.LdapUtils;
import org.apereo.cas.util.crypto.CipherExecutor;
import org.apereo.cas.webauthn.storage.WebAuthnCredentialRepository;
import org.ldaptive.ConnectionFactory;
import org.opensaml.saml.metadata.resolver.MetadataResolver;
import org.pac4j.core.client.Client;
import org.pac4j.core.client.IndirectClient;
import org.pac4j.saml.store.SAMLMessageStoreFactory;
Expand Down Expand Up @@ -304,19 +301,10 @@ public SamlIdPMetadataLocator samlIdPMetadataLocator(
final Cache<String, SamlIdPMetadataDocument> samlIdPMetadataCache,
final WARestClient waRestClient) {

return new WASamlIdPMetadataLocator(cipherExecutor, samlIdPMetadataCache, waRestClient);
}

@Bean
@RefreshScope(proxyMode = ScopedProxyMode.DEFAULT)
public SamlIdPObjectSigner samlObjectSigner(
final CasConfigurationProperties casProperties,
@Qualifier("casSamlIdPMetadataResolver")
final MetadataResolver casSamlIdPMetadataResolver,
@Qualifier("samlIdPMetadataLocator")
final SamlIdPMetadataLocator samlIdPMetadataLocator) {

return new WASamlIdPObjectSigner(casSamlIdPMetadataResolver, casProperties, samlIdPMetadataLocator);
return new WASamlIdPMetadataLocator(
cipherExecutor,
samlIdPMetadataCache,
waRestClient);
}

@Bean
Expand Down

This file was deleted.

0 comments on commit 7f600b7

Please sign in to comment.