Skip to content

Commit

Permalink
cpp: update includes
Browse files Browse the repository at this point in the history
* add missing include of "sstream" (seen when building with msvc)
* remove deprecated boost header

  While compiling ThrifttReadCheckTests.cpp I found this warning:
  /usr/include/boost/test/auto_unit_test.hpp:17:1: note: ‘#pragma message: This header is deprecated. Use <boost/test/unit_test.hpp> instead.’
     17 | BOOST_HEADER_DEPRECATED( "<boost/test/unit_test.hpp>" )
        | ^~~~~~~~~~~~~~~~~~~~~~~

  As this goes back to boost v1.34.0 (released in May 2007) we can switch the headerfile, without risking build errors.
  • Loading branch information
SvenRoederer authored and Jens-G committed Aug 28, 2024
1 parent 791f85c commit d80bb57
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions lib/cpp/src/thrift/TUuid.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#endif // THRIFT_TUUID_SUPPORT_BOOST_UUID

#include <algorithm>
#include <sstream>

namespace apache {
namespace thrift {
Expand Down
1 change: 0 additions & 1 deletion lib/cpp/test/ThrifttReadCheckTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#define MAX_MESSAGE_SIZE 2

#include <boost/test/auto_unit_test.hpp>
#include <boost/test/unit_test.hpp>
#include <iostream>
#include <climits>
Expand Down

0 comments on commit d80bb57

Please sign in to comment.