Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fasterxml #2912

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rakeshparuchuri
Copy link

No description provided.

@xiazcy
Copy link
Contributor

xiazcy commented Nov 26, 2024

Hi, thanks for opening the PR.

Could you clarify the reason for upgrading jackson-annotations, and why 2.15.0-rc1? We don't use release candidates, especially when there are newer official released versions.

Note that we are currently pinning jackson libraries to 2.13.x versions for compatibility reasons with Spark 2.3.3 (see comment on the pom file).

@rakeshparuchuri
Copy link
Author

Hi, thanks for opening the PR.

Could you clarify the reason for upgrading jackson-annotations, and why 2.15.0-rc1? We don't use release candidates, especially when there are newer official released versions.

Note that we are currently pinning jackson libraries to 2.13.x versions for compatibility reasons with Spark 2.3.3 (see comment on the pom file).

thanks @xiazcy for the reply
I have upgraded the dependency since it was vulnerable to one of the High severity issue.

I was't aware that we cannot upgrade to release candidates. I am committing again by upgrading to official released version.

@kenhuuu
Copy link
Contributor

kenhuuu commented Dec 3, 2024

Hi and thanks for contributing.

I was wondering what kind of testing you did for this PR. As noted earlier, it seems like this version was pinned for a reason. Have you looked into any potential issues with Spark/Scala if you change this Jackson version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants