Remove obsolete EJBContext methods #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity and isCallerInRole(Identity). Add overrides to prevent future removals going undetected.
eirbjo
changed the title
rzo1
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EJBContextmethodsgetEnvironment,getCallerIdentityandisCallerInRole(Identity)were removed in Jakarta EE 9, but their implementations remain inBaseContext.This PR suggests we remove these now-obsolete methods and also add
@Overrideannotations to prevent future removals going unnoticed.This also removed the depdency on the deprecated for-removal
java.security.Identityclass and allows TomEE to run on future JREs where this class has been removed.