-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Concurrency 3.0 #1458
Conversation
…ften unset openejb internal ThreadContext
…efinition resources
Note: We are currently looking into SXC to avoid to having to disable it here. Current status is, that we created a Jakarta-migrated version of SXC and @jungm started to integrated this version on a separate branch. If this works out, we can update it here. |
IMO we should not regenerate the SXC accessors in this PR, would make the diff absolutely huge and hard to review. |
Also there is currently one test failure left ( |
Yup. This is done in a separate PR but my comments aim to avoid merging this PR until we have re-generated the accessors because disabled something tends to be forgotten in the code base :) From my POV I would prefer:
Or are there any objections in doing so? I am also open to
|
+1 for your preferred suggestion, just don't want this PR to become like a 10k+ diff that's impossible to review |
# Conflicts: # container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiBeanInfo.java # container/openejb-jee/src/main/java/org/apache/openejb/jee/ApplicationClient.java # container/openejb-jee/src/main/java/org/apache/openejb/jee/EntityBean.java # container/openejb-jee/src/main/java/org/apache/openejb/jee/Interceptor.java # container/openejb-jee/src/main/java/org/apache/openejb/jee/MessageDrivenBean.java # container/openejb-jee/src/main/java/org/apache/openejb/jee/SessionBean.java # container/openejb-jee/src/main/java/org/apache/openejb/jee/WebApp.java # container/openejb-jee/src/main/java/org/apache/openejb/jee/WebFragment.java
I merged TCK is still passing on my machine and full build is green: https://ci-builds.apache.org/job/Tomee/view/tomee-10.x/job/pull-request-manual/130/ |
Implements the missing gap to pass the Jakarta Concurrency 3.0 TCK including:
Important: This change disables SXC for parsin web.xml, I wasn't able to get the sxc-maven-plugin to run on java 17/jaxb 4 in a meaningful time, probably needs some more workThanks to @rzo1 a full build for this branch is already running here
TCK results
tck/concurrency-standalone:
tck/concurrency-sigtest: