Reworked SXC #1469
Merged
Reworked SXC #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SXC has not seen any changes for the past 11 years (https://github.com/dblevins/sxc) and only has been working in TomEE because of it being shaded. However the maven plugin is not really usable anymore in the jakarta world nowadays.
@rzo1 created a fork of SXC here that has been upgraded to work with Jakarta XML Binding 4.0. This PR integrates this fork into tomee, drops the sxc shade and includes some changes in the JAXB Models to fix SXC accessor generation
IMO there are 3 topics:
openejb-jee-accessorsand move them to somewhere likeopenejb-jee/target/generated-sources? Would remove a lot of code from the tomee repo (just look at the diff size 😉) and force future developers to not modify generated code but its source instead