Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATC Collaborators for April 2022 #6710

Merged
merged 1 commit into from
Apr 11, 2022
Merged

ATC Collaborators for April 2022 #6710

merged 1 commit into from
Apr 11, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 1, 2022

This PR uses .asf.yaml to assign the GitHub Triage role to non-committer contributors who fixed 2 or more Issues in the past 31 days:

Congrats! For the month of April, @ocket8888 and @mattjackson220 will have the ability to

  • Apply labels to Issues and Pull Requests
  • Assign a user to an Issue (note that non-committers can be assigned to an Issue after commenting on it)
  • Add a user as a Reviewer of a Pull Request, which will send a request to them to review it
  • Mark Issues and Pull Requests as a duplicate

These privileges will expire at the end of April. If you want to be an Apache Traffic Control collaborator next month:
  1. Read our contribution guidelines
  2. Find an Issue to work on (recommended issues have the good first issue label) and ask to be assigned
  3. Get coding! For questions on how to contribute, you can reach the ATC community on

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

Verify that the fixed Issues listed above are linked to PRs from the past 31 days

PR submission checklist

@github-actions github-actions bot added collaborators Related to ATC collaborators (see .asf.yaml) process labels Apr 1, 2022
@zrhoffman zrhoffman marked this pull request as draft April 1, 2022 15:50
@ocket8888
Copy link
Contributor

It won't cause any real issues to mark committers as contributors, right? It does feel kinda self-congratulatory, but other than that I wouldn't think it functionally matters.

@zrhoffman
Copy link
Member

zrhoffman commented Apr 1, 2022

It depends on how ASF Infra implemented it. It might not cause issues, or it might lower your perms from Committer to Triage. Planning to fix this but have not gotten around to it since this PR came in

@zrhoffman zrhoffman added the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Apr 7, 2022
@@ -25,7 +25,8 @@
# - The ATC Development mailing list: https://trafficcontrol.apache.org/mailing_lists
github:
collaborators:
- davidc0le
- ocket8888
Copy link
Member

@mitchell852 mitchell852 Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zrhoffman interesting that it adds 2 committers that don't need this role. probably no harm though, right? and why is the PR in "draft" status?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably no harm though, right?

ehh let's find out

@zrhoffman zrhoffman marked this pull request as ready for review April 11, 2022 17:40
@zrhoffman zrhoffman merged commit e2d5211 into master Apr 11, 2022
@zrhoffman zrhoffman deleted the collaborators-2022-04 branch April 11, 2022 17:40
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this pull request Oct 2, 2022
Co-authored-by: asfgit <asfgit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collaborators Related to ATC collaborators (see .asf.yaml) process WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants