t3c parent.config fix for MSO non-topo mid cache group no parent cache groups #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7471 +/- ##
============================================
- Coverage 29.28% 27.45% -1.83%
Complexity 98 98
============================================
Files 782 685 -97
Lines 81860 77786 -4074
Branches 784 90 -694
============================================
- Hits 23970 21358 -2612
+ Misses 55825 54416 -1409
+ Partials 2065 2012 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 97 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jpappa200
suggested changes
May 1, 2023
ocket8888
added
bug
zrhoffman
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #7137 (create topology on the fly for non topo delivery services)
Case:
delivery service with MSO but no topology.
mid cache group does not have primary and secondary parents assigned.
origins belong to any number of origin cache groups.
In this case the origin from only the fist encountered cache group was getting pulled into parent.config
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Create delivery service, MSO non topo. Ensure origins belong to different origin cache groups. ensure the mid cache group has neither primary nor secondary cache groups assigned. T3C run parent.config should
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist