Replace gethostbyname_r() with getaddrinfo() #1328
Conversation
|
FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1334/ for details. |
|
Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1228/ for details. |
jablko
force-pushed
the
gethostbyname_r
branch
2 times, most recently
from
2209aff to
3a34b28
Compare
|
FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1335/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1229/ for details. |
jablko
force-pushed
the
gethostbyname_r
branch
from
3a34b28 to
416f07f
Compare
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1230/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1336/ for details. |
|
Sure I'll review this very soon. Was this the final dependency for openbsd? I know when I was looking into it way back when it looked like this was only going to be one piece of it. |
|
@bgaff Thanks! I messaged @jirib to see if building Traffic Server works for him now. This is the last of the four issues he reported, but yeah, I suspect there'll be more once his build gets past this point. Either way, I think this change is productive, since 1) it moves a step closer to building on this platform -- OpenBSD doesn't implement gethostbyname_r(), 2) "The gethostbyname*() and gethostbyaddr*() functions are obsolete." at least according to [1]. "Applications should use getaddrinfo(3) and getnameinfo(3) instead.", and 3) this is the only remaining occurrence of gethostbyname_r(), whereas we already depend on getaddrinfo() -- it's used elsewhere in the code. |
|
This looks good to me! 👍 Thanks Jack |
|
Shall I merge it? |
|
OpenBSD amd64 build passes this stage. |
jablko
force-pushed
the
gethostbyname_r
branch
from
416f07f to
fcf6e9d
Compare
|
Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1253/ for details. |
jablko
force-pushed
the
gethostbyname_r
branch
from
fcf6e9d to
57cbb3d
Compare
|
FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1360/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1361/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1254/ for details. |
|
Are you guys comfortable with cherry-picking this to 7.1.0? |
|
I dont think it's a good idea personally. The patch is trivial to backport and the only known benefit is openbsd support. IMO risk isn't worth the reward, just my two cents. |
|
I agree with @bgaff. |
Fixes #1312