Add Target Features RFC #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
reviewed
Jun 21, 2022
| The `Target` can be directly inspected: | ||
|
|
||
| ```python | ||
| if target.features.dsp: |
There was a problem hiding this comment.
should we adopt any namespacing? if so how would we represent that with this syntax?
There was a problem hiding this comment.
I'm hopeful for the initial pass we can work with target.features.X rather than further namespacing - most of what I've seen in other compilers is a flat array seems to work.
Happy to do a quick update on where this went 😸 |
|
If we add another member to |
The hope is to use the target parser to parse out the features as it'd just be an additional field we can set: target_json.Set("features", features_map); |
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Jul 18, 2022
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Jul 19, 2022
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
kparzysz-quic
pushed a commit
to apache/tvm
that referenced
this pull request
Jul 19, 2022
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
areusch
approved these changes
Aug 19, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.