Skip to content

Commit

Permalink
* review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Siva Rama Krishna Reddy B authored and srkreddy1238 committed Jan 2, 2023
1 parent a85e777 commit 9469b05
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 9 deletions.
6 changes: 1 addition & 5 deletions src/relay/backend/contrib/clml/codegen.cc
Original file line number Diff line number Diff line change
Expand Up @@ -328,11 +328,7 @@ class CLMLJSONSerializer : public backend::contrib::JSONSerializer {
const auto* dense = fn->body.as<CallNode>();
const CallNode* bias = nullptr;

if (backend::IsOp(dense, "add")) {
bias = dense;
dense = dense->args[0].as<CallNode>();
}
if (backend::IsOp(dense, "nn.bias_add")) {
if (backend::IsOp(dense, "add") || backend::IsOp(dense, "nn.bias_add")) {
bias = dense;
dense = dense->args[0].as<CallNode>();
}
Expand Down
3 changes: 2 additions & 1 deletion src/runtime/contrib/clml/clml_runtime.cc
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ class CLMLRuntime : public JSONRuntimeBase {
}
ICHECK(h_ClmlIntf != NULL)
<< "clGetMLInterfaceVxQCOM:" << result
<< " Perhaps there is mispatch between CLML SDK version to target supported version";
<< " Perhaps there is mispatch between CLML SDK version to target supported version:"
<< majorVersions[numVersions - 1];
char* tune_flag;
if ((tune_flag = getenv("CLML_IS_TUNNING_RUN")))
this->is_tuning_run = std::stoi(tune_flag);
Expand Down
1 change: 0 additions & 1 deletion tests/python/contrib/test_clml/test_ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ def _get_conv_expected_codegen(
weight_shape = (channels, shape[1] // groups, kernel_h, kernel_w)
else:
weight_shape = (shape[1] // groups, channels, kernel_h, kernel_w)
# weight_shape = (channels, shape[1] // groups, kernel_h, kernel_w)

if is_depthwise:
name = "nn.depthwise_conv2d"
Expand Down
2 changes: 0 additions & 2 deletions tests/scripts/task_config_build_adreno.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ mkdir -p "$BUILD_DIR"
cd "$BUILD_DIR"
cp ../cmake/config.cmake .

[[ -z "${ADRENO_OPENCL}" ]] && CLML_PATH='ON' || CLML_PATH="${ADRENO_OPENCL}"

echo set\(USE_OPENCL ON\) >> config.cmake
echo set\(USE_CLML ${CLML_PATH}\) >> config.cmake
echo set\(USE_RPC ON\) >> config.cmake
Expand Down

0 comments on commit 9469b05

Please sign in to comment.