Address Mehrdad's PR comments

apache · Aug 24, 2021 · a725574 · a725574
1 parent ef00c0d
commit a725574
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 28 deletions.
diff --git a/apps/microtvm/reference-vm/arduino/Vagrantfile b/apps/microtvm/reference-vm/arduino/Vagrantfile
@@ -63,27 +63,4 @@ Vagrant.configure("2") do |config|
     end
   end
 
-  config.vm.provider "parallels" do |prl, overrides|
-    prl.name = vm_name
-    prl.cpus = num_cores
-    prl.memory = ram_bytes
-    prl.update_guest_tools = true
-    prl.customize ["set", :id, "--support-usb30", "on"]
-    dirs_to_mount.each do |d|
-      overrides.vm.synced_folder d.to_s, d.to_s, mount_options: ["share", "nosuid", "host_inodes"]
-    end
-  end
-
-  config.vm.provider "vmware_desktop" do |vm, overrides|
-    vm.cpus = num_cores
-    vm.memory = ram_bytes
-    vm.vmx["usb_xhci.present"] = "TRUE"
-    vm.vmx["usb.present"] = "TRUE"
-    vm.vmx["ehci.present"] = "TRUE"
-    dirs_to_mount.each do |d|
-      overrides.vm.synced_folder d.to_s, d.to_s
-    end
-    vm.gui = true
-  end
-
 end
diff --git a/apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh b/apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh
@@ -33,6 +33,7 @@ microtvm_platform=$1
 pytest tests/micro/arduino/test_arduino_workflow.py --microtvm-platforms=${microtvm_platform}
 
 if [ $microtvm_platform == "nano33ble" ]; then
+    # https://github.com/apache/tvm/issues/8730
     echo "NOTE: skipped test_arduino_rpc_server.py on $microtvm_platform -- known failure"
 else
     pytest tests/micro/arduino/test_arduino_rpc_server.py --microtvm-platforms=${microtvm_platform}

diff --git a/apps/microtvm/reference-vm/base-box-tool.py b/apps/microtvm/reference-vm/base-box-tool.py
@@ -75,10 +75,7 @@
 # in [platform]/base-box/base_box_provision.sh
 EXTRA_SCRIPTS = {
     "arduino": (),
-    "zephyr": (
-        "docker/install/ubuntu_init_zephyr_project.sh",
-        "docker/install/ubuntu_install_qemu.sh",
-    ),
+    "zephyr": ("docker/install/ubuntu_init_zephyr_project.sh",),
 }
 
 PACKER_FILE_NAME = "packer.json"
@@ -392,7 +389,6 @@ def test_command(args):
         microtvm_test_platform["microtvm_platform"] = args.microtvm_platform
 
     providers = args.provider
-    print(providers)
     provider_passed = {p: False for p in providers}
 
     release_test_dir = os.path.join(THIS_DIR, "release-test")