Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Problem] Windows build fails when compiling RPC server #11220

Closed
Mousius opened this issue May 5, 2022 · 2 comments
Closed

[CI Problem] Windows build fails when compiling RPC server #11220

Mousius opened this issue May 5, 2022 · 2 comments
Labels
dev:ci

Comments

@Mousius
Copy link
Member

Mousius commented May 5, 2022 

C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(99,11): error C3646: 'PosixWrite': unknown override specifier (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_endpoint.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(99,21): error C2059: syntax error: '(' (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_endpoint.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(99,65): error C2334: unexpected token(s) preceding '{'; skipping apparent function body (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_endpoint.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(103,11): error C3646: 'PosixRead': unknown override specifier (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_endpoint.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(103,20): error C2059: syntax error: '(' (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_endpoint.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(103,58): error C2334: unexpected token(s) preceding '{'; skipping apparent function body (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_endpoint.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(99,11): error C3646: 'PosixWrite': unknown override specifier (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_event_impl.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(99,21): error C2059: syntax error: '(' (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_event_impl.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(99,65): error C2334: unexpected token(s) preceding '{'; skipping apparent function body (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_event_impl.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(103,11): error C3646: 'PosixRead': unknown override specifier (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_event_impl.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(103,20): error C2059: syntax error: '(' (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_event_impl.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]
C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_channel_logger.h(103,58): error C2334: unexpected token(s) preceding '{'; skipping apparent function body (compiling source file C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\src\runtime\rpc\rpc_event_impl.cc) [C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1651695603375\work\build\tvm_runtime_objs.vcxproj]

Branch/PR Failing

I think this was Introduced in #10967 which failed to build yet was still merged, unsure how that happened 🙀

Jenkins Link

Provide a link to the specific run that has failed.

cc @mehrdadh @areusch @kparzysz-quic
@Mousius Mousius mentioned this issue May 5, 2022
Merged
@mehrdadh
Copy link
Member

mehrdadh commented May 5, 2022

@Mousius thanks for reporting this! Will investigate today

leandron added a commit to leandron/tvm that referenced this issue May 6, 2022
@leandron
Revert "Implemented rpc logging (apache#10967)"
cec7891 
This reverts commit aa3bcd9, because it
fails on Windows CI as reported in issue apache#11220. PR apache#11223 tries to address
it but is is failing in the regular CI with testing issue on Hexagon.
@leandron leandron mentioned this issue May 6, 2022
Merged
manupak pushed a commit that referenced this issue May 6, 2022
@leandron
Revert "Implemented rpc logging (#10967)" (#11227)
ff7efe7 
This reverts commit aa3bcd9, because it
fails on Windows CI as reported in issue #11220. PR #11223 tries to address
it but is is failing in the regular CI with testing issue on Hexagon.
@areusch
Copy link
Contributor

areusch commented May 6, 2022

sorry for this break! can we close now that the revert is merged?

shtinsa pushed a commit to Deelvin/tvm that referenced this issue May 17, 2022
@leandron
Revert "Implemented rpc logging (apache#10967)" (apache#11227)
9f0d4f7 
This reverts commit aa3bcd9, because it
fails on Windows CI as reported in issue apache#11220. PR apache#11223 tries to address
it but is is failing in the regular CI with testing issue on Hexagon.
SebastianBoblest pushed a commit to SebastianBoblest/tvm that referenced this issue May 27, 2022
@leandron
Revert "Implemented rpc logging (apache#10967)" (apache#11227)
e6e93b7 
This reverts commit aa3bcd9, because it
fails on Windows CI as reported in issue apache#11220. PR apache#11223 tries to address
it but is is failing in the regular CI with testing issue on Hexagon.
@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@hpanda-naut hpanda-naut added dev:ci and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Nov 8, 2022
@tqchen tqchen closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@areusch @tqchen @Mousius @mehrdadh @hpanda-naut