[Relay][Pass] Add a relay pass to extract fake quantized ops #10089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margaretqian
requested review from
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
I will take a look tomorrow |
AndrewZhaoLuo
requested changes
Jan 28, 2022
| mod = tvm.IRModule.from_expr(op) | ||
| fake_quantized_op_freqs = relay.analysis.list_fake_quantized_op_freqs(mod) | ||
|
|
||
| assert len(fake_quantized_op_freqs) == 1 |
There was a problem hiding this comment.
I think you can just do direct equality throughout this file
dict(fake_quantized_op_freqs) == {"nn.conv2d": 1}
|
|
||
| using ExprSet = std::unordered_set<Expr, ObjectPtrHash, ObjectPtrEqual>; | ||
|
|
||
| class FakeQuantizedRegionExtractor : public ExprVisitor { |
There was a problem hiding this comment.
Can you just reuse SubgraphExtractor in src/relay/transforms/fake_quantization_to_integer.cc?
anwang2009
reviewed
Jan 28, 2022
added 2 commits
January 31, 2022 18:31
AndrewZhaoLuo
approved these changes
Feb 1, 2022
| * \file src/relay/transforms/fake_quantization_to_integer.h | ||
| * \brief Extract subgraph of a fake quantized region. | ||
| * | ||
| * https://llvm.org/doxygen/CallGraph_8h_source.html |
There was a problem hiding this comment.
This line is probably copypasta?
| if (op != dequantize_op_) { | ||
| if (fake_quantized_op_freqs_.find(op_name) != fake_quantized_op_freqs_.end()) { | ||
| fake_quantized_op_freqs_.Set(op_name, | ||
| int64_t(fake_quantized_op_freqs_.at(op_name)) + 1); |
There was a problem hiding this comment.
Why do you need to cast here?
There was a problem hiding this comment.
i was getting compile-time errors that fake_quantized_op_freqs_.at(op_name) + 1 is a PrimExpr instead of a tvm::Integer and it seemed like casting worked around the issue -- lmk if there's a better way around this?
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…10089) * add relay pass to collect fake quantized ops * add more tests * more tests * lint * lint * remove unused imports * update comment * lint * reuse SubgraphExtractor and update test assertions * remove print * lint * remove unneeded comment Co-authored-by: Margaret Qian <mqian@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a relay pass to collect fake quantized ops and frequencies from within fake quantized regions.