[build] Update libinfo and add lint rule #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
commented
Mar 24, 2022
| @@ -34,57 +34,84 @@ function(add_lib_info src_file) | |||
| SOURCE ${src_file} | |||
| APPEND | |||
| PROPERTY COMPILE_DEFINITIONS | |||
| TVM_CXX_COMPILER_PATH="${CMAKE_CXX_COMPILER}" | |||
There was a problem hiding this comment.
some of the churn here is just due to sorting the lines alphabetically
driazati
force-pushed
the
update_libinfo
branch
from
5d01361
to
8828be4
Compare
This updates `tvm.support.libinfo()` to be in-line with the current tvm options. It also adds a lint rule to ensure these stay matched up in the future as well as a script to print out the options in more detail. This should add in communication when debugging (i.e. tell someone to run `python -c 'import tvm; tvm.support.describe()` to learn everything you need about their envrionment)
driazati
force-pushed
the
update_libinfo
branch
from
d7027cc
to
096bbb9
Compare
|
It has been a while since this PR was updated, @leandron @areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please convert it to a draft until it is ready for review. |
junrushao
approved these changes
Apr 5, 2022
|
@areusch Shall we merge this PR? It looks perfect to me |
areusch
approved these changes
Apr 6, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [build] Update libinfo and add lint rule This updates `tvm.support.libinfo()` to be in-line with the current tvm options. It also adds a lint rule to ensure these stay matched up in the future as well as a script to print out the options in more detail. This should add in communication when debugging (i.e. tell someone to run `python -c 'import tvm; tvm.support.describe()` to learn everything you need about their envrionment) * Fix pylint Co-authored-by: driazati <driazati@users.noreply.github.com>
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
* [build] Update libinfo and add lint rule This updates `tvm.support.libinfo()` to be in-line with the current tvm options. It also adds a lint rule to ensure these stay matched up in the future as well as a script to print out the options in more detail. This should add in communication when debugging (i.e. tell someone to run `python -c 'import tvm; tvm.support.describe()` to learn everything you need about their envrionment) * Fix pylint Co-authored-by: driazati <driazati@users.noreply.github.com>
Lucien0
pushed a commit
to Lucien0/tvm
that referenced
this pull request
Apr 19, 2022
* [build] Update libinfo and add lint rule This updates `tvm.support.libinfo()` to be in-line with the current tvm options. It also adds a lint rule to ensure these stay matched up in the future as well as a script to print out the options in more detail. This should add in communication when debugging (i.e. tell someone to run `python -c 'import tvm; tvm.support.describe()` to learn everything you need about their envrionment) * Fix pylint Co-authored-by: driazati <driazati@users.noreply.github.com>
altanh
pushed a commit
to altanh/tvm
that referenced
this pull request
Apr 28, 2022
* [build] Update libinfo and add lint rule This updates `tvm.support.libinfo()` to be in-line with the current tvm options. It also adds a lint rule to ensure these stay matched up in the future as well as a script to print out the options in more detail. This should add in communication when debugging (i.e. tell someone to run `python -c 'import tvm; tvm.support.describe()` to learn everything you need about their envrionment) * Fix pylint Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
tvm.support.libinfo()to be in-line with the current tvm options. It also adds a lint rule to ensure these stay matched up in the future as well as a script to print out the options in more detail. This should aid in communication when debugging (i.e. tell someone to runpython -c 'import tvm; tvm.support.describe()'to learn everything you need about their envrionment)cc @areusch @leandron