Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use custom sphinx-gallery in ci_gpu #11023

Closed
wants to merge 1 commit into from
Closed

Conversation

driazati
Copy link
Member

@driazati driazati commented Apr 15, 2022

To enable #10921 this builds sphinx-gallery using @guberti's changes. Patch was created via

git clone https://github.com/sphinx-gallery/sphinx-gallery.git
cd sphinx-gallery
curl -L https://github.com/sphinx-gallery/sphinx-gallery/pull/940.diff | patch -p1 -d .
curl -L https://github.com/sphinx-gallery/sphinx-gallery/pull/941.diff | patch -p1 -d .
git diff > sphinx_gallery_colab_fixes.patch

cc @areusch

@driazati driazati force-pushed the colab branch 2 times, most recently from 3ebcd37 to 5283913 Compare April 15, 2022 18:45
@driazati driazati marked this pull request as ready for review April 15, 2022 18:50
@driazati driazati requested a review from areusch April 15, 2022 18:51
@guberti
Copy link
Member

guberti commented Apr 15, 2022

Thanks for the patch @driazati! For completeness, it's worth noting I had to make a third change to sphinx-gallery to get Python notebooks working again (sphinx-gallery/sphinx-gallery#943). That change was merged last night though, so nothing needs to change with this PR.

To enable apache#10921 this builds sphinx-gallery using @guberti's changes
@driazati
Copy link
Member Author

closing for now since we're going to revisit how we handle tutorials in a more generic way and this will make updating versions more difficult

@driazati driazati closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants